Changeset 769 in code for trunk/user.go

Timestamp:

Feb 4, 2022, 2:03:13 PM (3 years ago)

Author:

contact

Message:

Ensure consistent network ordering

Right now there is no consistent ordering in the network list:
no ORDER BY in the DB, and network updates move entries to the end.

Let's always sort by network ID so that users don't see the entries
move around.

I've contemplated sorting by Network.GetName() instead, but:

• Clients have now way to figure out dynamic order changes, e.g. when renaming a network.
• Some clients might use ISUPPORT NETWORK when a user hasn't explicitly named a network, but soju won't use that for ordering, leading to non-alphabetic ordering in the client.

Let's leave it to clients to sort the networks by display name if
they want to.

File:

• trunk/user.go (modified) (3 diffs)

trunk/user.go

@@ -9 +9 @@
         "math/big"
         "net"
+        "sort"
         "time"
 
@@ -517 +518 @@
         }
 
+        sort.Slice(networks, func(i, j int) bool {
+                return networks[i].ID < networks[j].ID
+        })
+
         for _, record := range networks {
                 record := record
@@ -766 +771 @@
 func (u *user) addNetwork(network *network) {
         u.networks = append(u.networks, network)
+
+        sort.Slice(u.networks, func(i, j int) bool {
+                return u.networks[i].ID < u.networks[j].ID
+        })
+
         go network.run()
 }