Changeset 469 in code for trunk/upstream.go

Timestamp:

Mar 16, 2021, 5:25:21 PM (4 years ago)

Author:

contact

Message:

Don't update downstream caps in upstream RPL_WELCOME handler

Prior to being registered, upstreamConn.handleMessage doesn't run
in the user goroutine, it runs in a goroutine specific to the
network. Thus we shouldn't access any user data structure from
there.

downstreamConn.updateSupportedCaps is already called from the
eventUpstreamConnected handler in user.run, the call being removed
was unnecessary.

Closes: ​https://todo.sr.ht/~emersion/soju/108

File:

• trunk/upstream.go (modified) (1 diff)

trunk/upstream.go

@@ -590 +590 @@
                 uc.registered = true
                 uc.logger.Printf("connection registered")
-
-                uc.forEachDownstream(func(dc *downstreamConn) {
-                        dc.updateSupportedCaps()
-                })
 
                 if len(uc.network.channels) > 0 {