Changeset 409 in code for trunk/server.go

Timestamp:

Aug 20, 2020, 6:05:01 PM (5 years ago)

Author:

contact

Message:

Nuke in-memory ring buffer

Instead, always read chat history from logs. Unify the implicit chat
history (pushing history to clients) and explicit chat history
(via the CHATHISTORY command).

Instead of keeping track of ring buffer cursors for each client, use
message IDs.

If necessary, the ring buffer could be re-introduced behind a
common MessageStore interface (could be useful when on-disk logs are
disabled).

References: ​https://todo.sr.ht/~emersion/soju/80

File:

• trunk/server.go (modified) (2 diffs)

trunk/server.go

@@ -48 +48 @@
         Hostname       string
         Logger         Logger
-        RingCap        int
         HistoryLimit   int
         LogPath        string
@@ -65 +64 @@
         return &Server{
                 Logger:       log.New(log.Writer(), "", log.LstdFlags),
-                RingCap:      4096,
                 HistoryLimit: 1000,
                 users:        make(map[string]*user),