Changeset 406 in code for trunk/user.go

Timestamp:

Aug 20, 2020, 3:38:57 PM (5 years ago)

Author:

contact

Message:

Replace networkHistory.offlineClients with clients

Keep the ring buffer alive even if all clients are connected. Keep the
ID of the latest delivered message even for online clients.

As-is, this is a net downgrade: memory usage increases because ring
buffers aren't free'd anymore. However upcoming commits will replace the
ring buffer with log files. This change makes reading from log files
easier.

File:

• trunk/user.go (modified) (3 diffs)

trunk/user.go

@@ -52 +52 @@
 
 type networkHistory struct {
-        offlineClients map[string]uint64 // indexed by client name
-        ring           *Ring             // can be nil if there are no offline clients
+        clients map[string]uint64 // indexed by client name
+        ring    *Ring             // can be nil if there are no offline clients
 }
 
@@ -194 +194 @@
                         net.forEachDownstream(func(dc *downstreamConn) {
                                 net.offlineClients[dc.clientName] = struct{}{}
-                                if history != nil {
-                                        history.offlineClients[dc.clientName] = history.ring.Cur()
-                                }
 
                                 dc.SendMessage(&irc.Message{
@@ -424 +421 @@
 
                                 net.offlineClients[dc.clientName] = struct{}{}
-                                for target, history := range net.history {
-                                        if ch, ok := net.channels[target]; ok && ch.Detached {
-                                                continue
-                                        }
-                                        history.offlineClients[dc.clientName] = history.ring.Cur()
-                                }
                         })