Changeset 406 in code for trunk/downstream.go

Timestamp:

Aug 20, 2020, 3:38:57 PM (5 years ago)

Author:

contact

Message:

Replace networkHistory.offlineClients with clients

Keep the ring buffer alive even if all clients are connected. Keep the
ID of the latest delivered message even for online clients.

As-is, this is a net downgrade: memory usage increases because ring
buffers aren't free'd anymore. However upcoming commits will replace the
ring buffer with log files. This change makes reading from log files
easier.

File:

• trunk/downstream.go (modified) (1 diff)

trunk/downstream.go

@@ -865 +865 @@
                 }
 
-                seq, ok := history.offlineClients[dc.clientName]
+                seq, ok := history.clients[dc.clientName]
                 if !ok {
                         continue
                 }
-                delete(history.offlineClients, dc.clientName)
-
-                // If all clients have received history, no need to keep the
-                // ring buffer around
-                if len(history.offlineClients) == 0 {
-                        delete(net.history, target)
-                }
+                history.clients[dc.clientName] = history.ring.Cur()
 
                 consumer := history.ring.NewConsumer(seq)