Changeset 350 in code for trunk/upstream.go

Timestamp:

Jul 6, 2020, 9:06:20 AM (5 years ago)

Author:

contact

Message:

Sort and split JOIN messages

Sort channels so that channels with a key appear first. Split JOIN
messages so that we don't reach the message size limit.

File:

• trunk/upstream.go (modified) (1 diff)

trunk/upstream.go

@@ -554 +554 @@
 
                 if len(uc.network.channels) > 0 {
-                        // TODO: split this into multiple messages if need be
-                        var names, keys []string
+                        var channels, keys []string
                         for _, ch := range uc.network.channels {
-                                names = append(names, ch.Name)
+                                channels = append(channels, ch.Name)
                                 keys = append(keys, ch.Key)
                         }
-                        uc.SendMessage(&irc.Message{
-                                Command: "JOIN",
-                                Params: []string{
-                                        strings.Join(names, ","),
-                                        strings.Join(keys, ","),
-                                },
-                        })
+
+                        for _, msg := range join(channels, keys) {
+                                uc.SendMessage(msg)
+                        }
                 }
         case irc.RPL_MYINFO: