Changeset 333 in code for trunk/service.go

Timestamp:

Jun 10, 2020, 2:18:15 PM (5 years ago)

Author:

kl

Message:

service: Handle zero-value in stringPtrFlag.String

FlagSet.PrintDefaults uses reflection to construct a zero value, calls
.String on it, and compares the result with the current flag value to
detect zero-value flags. For stringPtrFlag, this would result in a
panic, as String() always dereferenced the first level of its string.

Add another check so that both pointer levels are nil-checked.

File:

• trunk/service.go (modified) (1 diff)

trunk/service.go

@@ -251 +251 @@
 
 func (f stringPtrFlag) String() string {
-        if *f.ptr == nil {
+        if f.ptr == nil || *f.ptr == nil {
                 return ""
         }