Changeset 319 in code for trunk/downstream.go

Timestamp:

Jun 5, 2020, 9:50:31 PM (5 years ago)

Author:

delthas

Message:

Add support for downstream CHATHISTORY

This adds support for the WIP (at the time of this commit)
draft/chathistory extension, based on the draft at [1] and the
additional comments at [2].

This gets the history by parsing the chat logs, and is therefore only
enabled when the logs are enabled and the log path is configured.

Getting the history only from the logs adds some restrictions:

• we cannot get history by msgid (those are not logged)
• we cannot get the users masks (maybe they could be inferred from the JOIN etc, but it is not worth the effort and would not work every time)

The regular soju network history is not sent to clients that support
draft/chathistory, so that they can fetch what they need by manually
calling CHATHISTORY.

The only supported command is BEFORE for now, because that is the only
required command for an app that offers an "infinite history scrollback"
feature.

Regarding implementation, rather than reading the file from the end in
reverse, we simply start from the beginning of each log file, store each
PRIVMSG into a ring, then add the last lines of that ring into the
history we'll return later. The message parsing implementation must be
kept somewhat fast because an app could potentially request thousands of
messages in several files. Here we are using simple sscanf and indexOf
rather than regexps.

In case some log files do not contain any message (for example because
the user had not joined a channel at that time), we try up to a 100 days
of empty log files before giving up.

[1]: ​https://github.com/prawnsalad/ircv3-specifications/pull/3/files
[2]: ​https://github.com/ircv3/ircv3-specifications/pull/393/files#r350210018

File:

• trunk/downstream.go (modified) (5 diffs)

trunk/downstream.go

@@ -43 +43 @@
                         "Not enough parameters",
                 },
+        }}
+}
+
+func newChatHistoryError(subcommand string, target string) ircError {
+        return ircError{&irc.Message{
+                Command: "FAIL",
+                Params:  []string{"CHATHISTORY", "MESSAGE_ERROR", subcommand, target, "Messages could not be retrieved"},
         }}
 }
@@ -107 +114 @@
         for k, v := range permanentDownstreamCaps {
                 dc.supportedCaps[k] = v
+        }
+        if srv.LogPath != "" {
+                dc.supportedCaps["draft/chathistory"] = ""
         }
         return dc
@@ -786 +796 @@
         })
         // TODO: RPL_ISUPPORT
+        // TODO: send CHATHISTORY in RPL_ISUPPORT when implemented
         dc.SendMessage(&irc.Message{
                 Prefix:  dc.srv.prefix(),
@@ -826 +837 @@
 
 func (dc *downstreamConn) sendNetworkHistory(net *network) {
+        if dc.caps["draft/chathistory"] {
+                return
+        }
         for target, history := range net.history {
                 if ch, ok := net.channels[target]; ok && ch.Detached {
@@ -1511 +1525 @@
                         Params:  []string{upstreamUser, upstreamChannel},
                 })
+        case "CHATHISTORY":
+                var subcommand string
+                if err := parseMessageParams(msg, &subcommand); err != nil {
+                        return err
+                }
+                var target, criteria, limitStr string
+                if err := parseMessageParams(msg, nil, &target, &criteria, &limitStr); err != nil {
+                        return ircError{&irc.Message{
+                                Command: "FAIL",
+                                Params:  []string{"CHATHISTORY", "NEED_MORE_PARAMS", subcommand, "Missing parameters"},
+                        }}
+                }
+
+                if dc.srv.LogPath == "" {
+                        return ircError{&irc.Message{
+                                Command: irc.ERR_UNKNOWNCOMMAND,
+                                Params:  []string{dc.nick, subcommand, "Unknown command"},
+                        }}
+                }
+
+                uc, entity, err := dc.unmarshalEntity(target)
+                if err != nil {
+                        return err
+                }
+
+                // TODO: support msgid criteria
+                criteriaParts := strings.SplitN(criteria, "=", 2)
+                if len(criteriaParts) != 2 || criteriaParts[0] != "timestamp" {
+                        return ircError{&irc.Message{
+                                Command: "FAIL",
+                                Params:  []string{"CHATHISTORY", "UNKNOWN_CRITERIA", criteria, "Unknown criteria"},
+                        }}
+                }
+
+                timestamp, err := time.Parse(serverTimeLayout, criteriaParts[1])
+                if err != nil {
+                        return ircError{&irc.Message{
+                                Command: "FAIL",
+                                Params:  []string{"CHATHISTORY", "INVALID_CRITERIA", criteria, "Invalid criteria"},
+                        }}
+                }
+
+                limit, err := strconv.Atoi(limitStr)
+                if err != nil || limit < 0 || limit > dc.srv.HistoryLimit {
+                        return ircError{&irc.Message{
+                                Command: "FAIL",
+                                Params:  []string{"CHATHISTORY", "INVALID_LIMIT", limitStr, "Invalid limit"},
+                        }}
+                }
+
+                switch subcommand {
+                case "BEFORE":
+                        batchRef := "history"
+                        dc.SendMessage(&irc.Message{
+                                Prefix:  dc.srv.prefix(),
+                                Command: "BATCH",
+                                Params:  []string{"+" + batchRef, "chathistory", target},
+                        })
+
+                        history := make([]*irc.Message, limit)
+                        remaining := limit
+
+                        tries := 0
+                        for remaining > 0 {
+                                buf, err := parseMessagesBefore(uc.network, entity, timestamp, remaining)
+                                if err != nil {
+                                        dc.logger.Printf("failed parsing log messages for chathistory: %v", err)
+                                        return newChatHistoryError(subcommand, target)
+                                }
+                                if len(buf) == 0 {
+                                        tries++
+                                        if tries >= 100 {
+                                                break
+                                        }
+                                } else {
+                                        tries = 0
+                                }
+                                copy(history[remaining-len(buf):], buf)
+                                remaining -= len(buf)
+                                year, month, day := timestamp.Date()
+                                timestamp = time.Date(year, month, day, 0, 0, 0, 0, timestamp.Location()).Add(-1)
+                        }
+
+                        for _, m := range history[remaining:] {
+                                m.Tags["batch"] = irc.TagValue(batchRef)
+                                dc.SendMessage(dc.marshalMessage(m, uc.network))
+                        }
+
+                        dc.SendMessage(&irc.Message{
+                                Prefix:  dc.srv.prefix(),
+                                Command: "BATCH",
+                                Params:  []string{"-" + batchRef},
+                        })
+                default:
+                        // TODO: support AFTER, LATEST, BETWEEN
+                        return ircError{&irc.Message{
+                                Command: "FAIL",
+                                Params:  []string{"CHATHISTORY", "UNKNOWN_COMMAND", subcommand, "Unknown command"},
+                        }}
+                }
         default:
                 dc.logger.Printf("unhandled message: %v", msg)