Changeset 295 in code for trunk/upstream.go

Timestamp:

May 21, 2020, 8:38:07 PM (5 years ago)

Author:

delthas

Message:

Fix sending CAP END twice when SASL is not used

When SASL is not used, we should only send CAP END after we send a CAP
REQ. Previously CAP END was sent both after a CAP REQ and a CAP ACK,
resulting in two CAP END messages.

Sending a CAP END right after the CAP REQ rather than waiting for the
CAP ACK/NAK saves 1 RTT.

File:

• trunk/upstream.go (modified) (1 diff)

trunk/upstream.go

@@ -397 +397 @@
                                         return err
                                 }
-                        }
-
-                        if uc.saslClient == nil {
-                                uc.SendMessage(&irc.Message{
-                                        Command: "CAP",
-                                        Params:  []string{"END"},
-                                })
                         }