Changeset 218 in code for trunk/upstream.go

Timestamp:

Apr 4, 2020, 3:33:09 PM (5 years ago)

Author:

delthas

Message:

Send one NOTICE on new upstream disconnect/connect errors

In order to notify the user when we are disconnected from a network
(either due to an error, or due a QUIT), and when we fail reconnecting,
this commit adds support for sending a short NOTICE message from the
service user to all relevant downstreams.

The last error is stored, and cleared on successful connection, to
ensure that the user is *not* flooded with identical connection error
messages, which can often happen when a server is down.

No lock is needed on lastError because it is only read and modified from
the user goroutine.

Closes: ​https://todo.sr.ht/~emersion/soju/27

File:

• trunk/upstream.go (modified) (1 diff)

trunk/upstream.go

@@ -104 +104 @@
 
 func (uc *upstreamConn) forEachDownstream(f func(*downstreamConn)) {
-        uc.user.forEachDownstream(func(dc *downstreamConn) {
-                if dc.network != nil && dc.network != uc.network {
-                        return
-                }
-                f(dc)
-        })
+        uc.network.forEachDownstream(f)
 }