Changeset 167 in code for trunk/downstream.go

Timestamp:

Mar 27, 2020, 4:55:03 PM (5 years ago)

Author:

contact

Message:

Add eventDownstreamDisconnected

This should remove the need for protecting user.downstreamConns with a
mutex.

File:

• trunk/downstream.go (modified) (2 diffs)

trunk/downstream.go

@@ -309 +309 @@
         if dc.isClosed() {
                 return fmt.Errorf("downstream connection already closed")
-        }
-
-        if u := dc.user; u != nil {
-                u.removeDownstream(dc)
         }
 
@@ -758 +754 @@
                 seq := consumer.Close()
 
-                // TODO: need to take dc.network into account here
-                dc.user.lock.Lock()
-                lastDownstream := len(dc.user.downstreamConns) == 0
-                dc.user.lock.Unlock()
-
-                if lastDownstream {
-                        net.lock.Lock()
-                        net.history[historyName] = seq
-                        net.lock.Unlock()
-                }
+                net.lock.Lock()
+                net.history[historyName] = seq
+                net.lock.Unlock()
         }()
 }