Changeset 103 in code for trunk/upstream.go

Timestamp:

Mar 16, 2020, 11:44:59 AM (5 years ago)

Author:

contact

Message:

Per-user dispatcher goroutine

This allows message handlers to read upstream/downstream connection
information without causing any race condition.

References: ​https://todo.sr.ht/~emersion/soju/1

File:

• trunk/upstream.go (modified) (2 diffs)

trunk/upstream.go

@@ -660 +660 @@
 }
 
-func (uc *upstreamConn) readMessages() error {
+func (uc *upstreamConn) readMessages(ch chan<- upstreamIncomingMessage) error {
         for {
                 msg, err := uc.irc.ReadMessage()
@@ -673 +673 @@
                 }
 
-                if err := uc.handleMessage(msg); err != nil {
-                        uc.logger.Printf("failed to handle message %q: %v", msg, err)
-                }
+                ch <- upstreamIncomingMessage{msg, uc}
         }