Changeset 10 in code for trunk/engines/iciba.go

Timestamp:

Sep 30, 2022, 8:16:23 PM (3 years ago)

Author:

fattalion

Message:

Make some identifiers more concise

See ​https://go.dev/doc/effective_go#package-names, specifically:

The importer of a package will use the name to refer to its contents,
so exported names in the package can use that fact to avoid
repetition.

For example, engines.GoogleTranslateEngine needlessly repeats
"engine," so just get rid of that duplication by renaming it to
engines.GoogleTranslate.

Renaming engines.TranslationEngine to engines.Engine may be
debatable, so if somebody disagrees, feel free to leave a comment
stating your disagreement and with an explanation of why you disagree.

File:

• trunk/engines/iciba.go (modified) (3 diffs)

trunk/engines/iciba.go

@@ -10 +10 @@
 )
 
-// ICIBAEngine is an engine that fetches data from https://www.iciba.com.
-type ICIBAEngine struct{}
-
-func (_ *ICIBAEngine) InternalName() string { return "iciba" }
-
-func (_ *ICIBAEngine) DisplayName() string { return "iCIBA" }
+// ICIBA is an engine that fetches data from https://www.iciba.com.
+type ICIBA struct{}
+
+func (_ *ICIBA) InternalName() string { return "iciba" }
+
+func (_ *ICIBA) DisplayName() string { return "iCIBA" }
 
 var icibaLanguages = []Language{
@@ -212 +212 @@
 }
 
-func (_ *ICIBAEngine) SourceLanguages() ([]Language, error) { return icibaLanguages, nil }
-
-func (_ *ICIBAEngine) TargetLanguages() ([]Language, error) { return icibaLanguages, nil }
-
-func (_ *ICIBAEngine) SupportsAutodetect() bool { return true }
-
-func (_ *ICIBAEngine) DetectLanguage(text string) (Language, error) { return Language{}, nil }
+func (_ *ICIBA) SourceLanguages() ([]Language, error) { return icibaLanguages, nil }
+
+func (_ *ICIBA) TargetLanguages() ([]Language, error) { return icibaLanguages, nil }
+
+func (_ *ICIBA) SupportsAutodetect() bool { return true }
+
+func (_ *ICIBA) DetectLanguage(text string) (Language, error) { return Language{}, nil }
 
 type icibaTranslateResponse struct {
@@ -227 +227 @@
 }
 
-func (_ *ICIBAEngine) Translate(text string, from Language, to Language) (TranslationResult, error) {
+func (_ *ICIBA) Translate(text string, from Language, to Language) (TranslationResult, error) {
         requestURL, err := url.Parse("https://ifanyi.iciba.com/index.php")