Changeset e68221b in code for icbd.c

Timestamp:

Jun 23, 2014, 1:02:33 PM (11 years ago)

Author:

Florian Obser <florian@…>

Branches:

master

Children:

96a2e31

Parents:

120eedd

Message:

Check that the reverse resolved hostname resolves back to the
connecting IP.

File:

• icbd.c (modified) (2 diffs)

icbd.c

@@ -586 +586 @@
 getpeerinfo(struct icb_session *is)
 {
-        struct sockaddr_storage ss;
-        struct sockaddr_in *sin = (struct sockaddr_in *)&ss;
-        struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)&ss;
-        socklen_t ss_len = sizeof ss;
-
-        bzero(&ss, sizeof ss);
-        if (getpeername(EVBUFFER_FD(is->bev), (struct sockaddr *)&ss,
+        struct sockaddr_in *sin = (struct sockaddr_in *)&is->ss;
+        struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)&is->ss;
+        socklen_t ss_len = sizeof is->ss;
+
+        bzero(&is->ss, sizeof is->ss);
+        if (getpeername(EVBUFFER_FD(is->bev), (struct sockaddr *)&is->ss,
             &ss_len) != 0)
                 return;
 
         is->port = 0;
-        switch (ss.ss_family) {
+        switch (is->ss.ss_family) {
         case AF_INET:
                 is->port = ntohs(sin->sin_port);
@@ -607 +606 @@
         }
 
-        inet_ntop(ss.ss_family, ss.ss_family == AF_INET ?
+        inet_ntop(is->ss.ss_family, is->ss.ss_family == AF_INET ?
             (void *)&sin->sin_addr : (void *)&sin6->sin6_addr,
             is->host, sizeof is->host);
 
-        dns_resolve(is, (struct sockaddr *)&ss);
-}
+        dns_resolve(is);
+}