Changeset a2fadb4 in code for icb.c

Timestamp:

Mar 7, 2014, 3:21:30 PM (11 years ago)

Author:

Mike Belopuhov <mike@…>

Branches:

master

Children:

8871953

Parents:

270fd23

git-author:

Mike Belopuhov <mike@…> (03/07/14 15:17:23)

git-committer:

Mike Belopuhov <mike@…> (03/07/14 15:21:30)

Message:

Get rid of ICB_MSGSIZE+1, fix various off-by-ones and do some truncation
where necessary.

File:

• icb.c (modified) (4 diffs)

icb.c

@@ -82 +82 @@
 
         is->last = getmonotime();
-        type = msg[1];
-        msg += 2;
+        type = msg[0];
+        msg++;
         if (!ISSETF(is->flags, ICB_SF_LOGGEDIN) && type != ICB_M_LOGIN) {
                 icb_error(is, "Not logged in");
@@ -378 +378 @@
     const char *fmt, ...)
 {
-        char buf[ICB_MSGSIZE];
+        char buf[ICB_MSGSIZE - 10]; /* truncate to make sure all fits */
         va_list ap;
         struct icb_session *s;
@@ -481 +481 @@
 icb_dowho(struct icb_session *is, struct icb_group *ig)
 {
-        char buf[ICB_MSGSIZE];
+        char buf[ICB_MSGSIZE - 10]; /* truncate to make sure all fits */
         struct icb_session *s;
         int nusers = 0;
@@ -510 +510 @@
 icb_who(struct icb_session *is, struct icb_group *ig)
 {
-        char buf[ICB_MSGSIZE];
+        char buf[ICB_MSGSIZE - 10]; /* truncate to make sure all fits */
         struct icb_group *g;