Changeset 756 in code

Timestamp:

Dec 8, 2021, 2:00:02 PM (4 years ago)

Author:

contact

Message:

server: cleanup user in defer

If a user goroutine panics, this correctly removes it from the
global map instead of leaving a dangling entry behind.

File:

• trunk/server.go (modified) (1 diff)

trunk/server.go

@@ -287 +287 @@
                                 s.Logger.Printf("panic serving user %q: %v\n%v", user.Username, err, debug.Stack())
                         }
+
+                        s.lock.Lock()
+                        delete(s.users, u.Username)
+                        s.lock.Unlock()
+
+                        s.stopWG.Done()
                 }()
 
                 u.run()
-
-                s.lock.Lock()
-                delete(s.users, u.Username)
-                s.lock.Unlock()
-
-                s.stopWG.Done()
         }()