Changeset 688 in code for trunk

Timestamp:

Nov 15, 2021, 8:30:04 PM (4 years ago)

Author:

delthas

Message:

Return an empty CHATHISTORY TARGETS batch when in multi-upstream

When on an unbound bouncer network downstream, we should return no
targets (there are none, because there are no upstreams at all).

When on a multi-upstream downstream, we should return no targets as we
don't support multi-upstream CHATHISTORY TARGETS.

Before this patch, we returned a misleading error message:
:example.com 403 :Missing network suffix in name

File:

• trunk/downstream.go (modified) (1 diff)

trunk/downstream.go

@@ -2360 +2360 @@
                         }
                 case "TARGETS":
+                        if dc.network == nil {
+                                // Either an unbound bouncer network, in which case we should return no targets,
+                                // or a multi-upstream downstream, but we don't support CHATHISTORY TARGETS for those yet.
+                                dc.SendBatch("draft/chathistory-targets", nil, nil, func(batchRef irc.TagValue) {})
+                                return nil
+                        }
                         if err := parseMessageParams(msg, nil, &boundsStr[0], &boundsStr[1], &limitStr); err != nil {
                                 return err