Changeset 610 in code for trunk

Timestamp:

Oct 7, 2021, 9:57:42 AM (4 years ago)

Author:

alex

Message:

chathistory: Fix truncated backlog due to timezones

Because msgstore_fs writes logs in localtime, the CHATHISTORY timestamps
(UTC) must be converted to localtime prior to filtering ranges ensure
the right range is sent back to the client.

Prior to this patch, the iteration back from the BEFORE time failed to
load the hours between midnight UTC and midnight localtime in each day's
logged messages. This is because the final time to be considered in a
day's log file (the "start" time) reuses the previous start time's
locale:

start = time.Date(year, month, day, 0, 0, 0, 0, start.Location()).Add(-1)

By converting the original start and end from the CHATHISTORY commands
to localtime in Load*Time and ListTargets, we ensure we read through
midnight each day.

File:

• trunk/msgstore_fs.go (modified) (3 diffs)

trunk/msgstore_fs.go

@@ -384 +384 @@
 
 func (ms *fsMessageStore) LoadBeforeTime(network *network, entity string, start time.Time, end time.Time, limit int) ([]*irc.Message, error) {
+        start = start.In(time.Local)
+        end = end.In(time.Local)
         history := make([]*irc.Message, limit)
         remaining := limit
@@ -407 +409 @@
 
 func (ms *fsMessageStore) LoadAfterTime(network *network, entity string, start time.Time, end time.Time, limit int) ([]*irc.Message, error) {
+        start = start.In(time.Local)
+        end = end.In(time.Local)
         var history []*irc.Message
         remaining := limit
@@ -473 +477 @@
 
 func (ms *fsMessageStore) ListTargets(network *network, start, end time.Time, limit int) ([]chatHistoryTarget, error) {
+        start = start.In(time.Local)
+        end = end.In(time.Local)
         rootPath := filepath.Join(ms.root, escapeFilename(network.GetName()))
         root, err := os.Open(rootPath)