Changeset 413 in code

Timestamp:

Aug 26, 2020, 1:28:10 PM (5 years ago)

Author:

contact

Message:

Fix panic in downstreamConn.sendNetworkHistory

This panic happens when sending history to a multi-upstream client.
sendNetworkHistory is called on each network, but dc.network is nil.

Closes: ​https://todo.sr.ht/~emersion/soju/93

File:

• trunk/downstream.go (modified) (2 diffs)

trunk/downstream.go

@@ -887 +887 @@
 
                 limit := 4000
-                history, err := loadHistoryLatestID(dc.network, target, lastDelivered, limit)
+                history, err := loadHistoryLatestID(net, target, lastDelivered, limit)
                 if err != nil {
                         dc.logger.Printf("failed to send implicit history for %q: %v", target, err)
@@ -971 +971 @@
                         return ircError{&irc.Message{
                                 Command: irc.ERR_NOSUCHSERVER,
-                                Params: []string{dc.nick, destination, "No such server"},
+                                Params:  []string{dc.nick, destination, "No such server"},
                         }}
                 }