Changeset 283 in code for trunk

Timestamp:

May 1, 2020, 8:49:58 AM (5 years ago)

Author:

delthas

Message:

Fix joining only one saved channel per network

This fixes a serious bug added in 276ce12e, where in newNetwork all
channels point to the same channel, which causes soju to only join a
single channel when connecting to an upstream network.

This also adds the same kind of reassignment of a for loop variable in
user.run(), even though that function currently works correctly, as a
sanity improvement in case this function is changed in the future.

File:

• trunk/user.go (modified) (2 diffs)

trunk/user.go

@@ -66 +66 @@
         m := make(map[string]*Channel, len(channels))
         for _, ch := range channels {
+                ch := ch
                 m[ch.Name] = &ch
         }
@@ -230 +231 @@
 
         for _, record := range networks {
+                record := record
                 channels, err := u.srv.db.ListChannels(record.ID)
                 if err != nil {