Changeset 220 in code for trunk

Timestamp:

Apr 4, 2020, 3:34:30 PM (5 years ago)

Author:

delthas

Message:

Fill all fields of the service user prefix

On some IRC clients, NOTICE messages from a user which does not have a
user or host in its prefix (and therefore only have a Name, and look
like prefixes of servers), are treated as server notices rather than
user notices, and are treated differently. (For that matter, soju also
considers NOTICE messages from users with only a Name in their prefix as
special server messages). On most of these clients, NOTICE messages from
a user are formatted differently and stand out from the large flow of
incoming misceallenous server messages.

This fills the service user with fake User and Host values so that
NOTICE messages from it correctly appear as coming from a user. This
is particularly useful in the context of connection and disconnect
errors NOTICE messages that are broadcast from the service user to all
relevant downstreams.

File:

• trunk/service.go (modified) (3 diffs)

trunk/service.go

@@ -13 +13 @@
 const serviceNick = "BouncerServ"
 
+var servicePrefix = &irc.Prefix{
+        Name: serviceNick,
+        User: serviceNick,
+        Host: serviceNick,
+}
+
 type serviceCommandSet map[string]*serviceCommand
 
@@ -24 +30 @@
 func sendServiceNOTICE(dc *downstreamConn, text string) {
         dc.SendMessage(&irc.Message{
-                Prefix:  &irc.Prefix{Name: serviceNick},
+                Prefix:  servicePrefix,
                 Command: "NOTICE",
                 Params:  []string{dc.nick, text},
@@ -32 +38 @@
 func sendServicePRIVMSG(dc *downstreamConn, text string) {
         dc.SendMessage(&irc.Message{
-                Prefix:  &irc.Prefix{Name: serviceNick},
+                Prefix:  servicePrefix,
                 Command: "PRIVMSG",
                 Params:  []string{dc.nick, text},