Changeset 6 in code

Timestamp:

Oct 11, 2022, 7:34:08 PM (3 years ago)

Author:

koizumi.aoi

Message:

Use variable quoting

Signed-off-by: Aoi K <koizumi.aoi@…>

File:

• trunk/kanako (modified) (5 diffs)

trunk/kanako

@@ -1 +1 @@
 #!/bin/sh -e
 
-conf_dir=${conf_dir:-$HOME/.config/kanako}
-key_dir=${key_dir:-$HOME/.kanako}
-store_dir=${store_dir:-$HOME/.kanako-store}
+conf_dir="${conf_dir:-$HOME/.config/kanako}"
+key_dir="${key_dir:-$HOME/.kanako}"
+store_dir="${store_dir:-$HOME/.kanako-store}"
 
-if test -d ${store_dir}; then
-        cd ${store_dir}
+if test -d "${store_dir}"; then
+        cd "${store_dir}"
 else
         echo "Password store not found!"
@@ -13 +13 @@
 fi
 
-if test -f ${conf_dir}/kanako.conf; then
-        . ${conf_dir}/kanako.conf;
+if test -f "${conf_dir}/kanako.conf"; then
+        . "${conf_dir}/kanako.conf";
 else
         echo "Configuration file has not been found!"
@@ -23 +23 @@
 
 fn_copy() {
-    fn_view $1 | ${clip_cmd}
+    fn_view $1 | "${clip_cmd}"
 }
 fn_edit() {
-    ${decrypt_cmd} ${decrypt_args} ${1%%.enc}.enc > ${1%%.enc}
-    ${EDITOR} ${1%%.enc}
-    ${encrypt_cmd} ${encrypt_args} ${1%%.enc} > ${1%%.enc}.enc
-    rm ${1%%.enc}
+    "${decrypt_cmd}" "${decrypt_args}" "${1%%.enc}.enc" > "${1%%.enc}"
+    "${EDITOR}" "${1%%.enc}"
+    "${encrypt_cmd}" "${encrypt_args}" "${1%%.enc}" > "${1%%.enc}".enc
+    rm "${1%%.enc}"
 }
 fn_generate() {
-    pwgen -s ${1:-80}
+    pwgen -s "${1:-80}"
 }
 fn_list() {
-    ${list_cmd} ${store_dir}
+    "${list_cmd}" "${store_dir}"
 }
 fn_new() {
     test -d $1 && fn_usage && exit 1
 
-    tmpfile=$(mktemp)
-    ${EDITOR} ${tmpfile}
+    tmpfile="$(mktemp)"
+    "${EDITOR}" "${tmpfile}"
 
-    mkdir -p $(dirname $1)
-    ${encrypt_cmd} ${encrypt_args} ${tmpfile} > ${1%%.enc}.enc
+    mkdir -p "$(dirname "$1")"
+    "${encrypt_cmd}" "${encrypt_args}" "${tmpfile}" > "${1%%.enc}".enc
     rm ${tmpfile}
 }
@@ -51 +51 @@
 }
 fn_trash_entry() {
-    rm -f ${1}${2},enc
+    rm -f "${1}${2}".enc
 }
 fn_usage() {
@@ -61 +61 @@
 }
 fn_view() {
-    if [ -f ${1%%.enc}.enc ]; then
-        ${encrypt_cmd} ${decrypt_args} ${1%%.enc}.enc
-    elif [ -d ${1:-.} ]; then
-        ${list_cmd} ${1:-.}
+    if [ -f "${1%%.enc}".enc ]; then
+        ${encrypt_cmd} ${decrypt_args} "${1%%.enc}".enc
+    elif [ -d "${1:-.}" ]; then
+        ${list_cmd} "${1:-.}"
     else
         fn_usage